This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Make sure regress tests are all green on travis #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It certainly fails in my house. I have Vodafone Italy and I have not disabled the "rete sicura" option, which does DNS hijacking. I used to have it disabled, but then I moved and now I am again using the default value of that setting. So, I figured it made sense to run all tests and mark those which are going to fail if you're under a similar setup. (Making them pass under such conditions is probably not what I want.)
The test assumed there was no redirect when accessing ooni.io but it has recently changed to redirect to ooni.org. By changing the input URL for this integration test, we fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by failures in #144. While there, mention with documentation which tests are gonna fail if you are using DNS hijacking ISP settings like Vodafone Italia does by default.